UIE-200 Ajax cleanup pt7 #5077
Open
UIE-200 Ajax cleanup pt7 #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilva-broad
force-pushed
the
msilva/UIE-200_Ajax-cleanup_pt7
branch
from
81d6bee
to
460acff
Compare
cahrens
reviewed
Sep 12, 2024
| import { fetchGoogleForms } from 'src/libs/ajax/ajax-common'; | ||
|
|
||
| export const Surveys = (signal?: AbortSignal) => ({ | ||
| submitForm: (formId, data) => fetchGoogleForms(`${formId}/formResponse?${qs.stringify(data)}`, { signal }), |
There was a problem hiding this comment.
The comment on the PR indicates that you intended to remove this.
There was a problem hiding this comment.
oops! I updated PR description... that was a left-over from the last PR
- breakout Surveys ajax.ts sub-area.
msilva-broad
force-pushed
the
msilva/UIE-200_Ajax-cleanup_pt7
branch
from
460acff
to
f68bc42
Compare
cahrens
approved these changes
Sep 12, 2024
|
jdcanas
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/[Ticket #]
Summary of changes:
What
Why
Testing strategy