[DC-1176] Learn More About OMOP Popover #5086
Conversation
| @@ -89,6 +92,8 @@ export const computePopupPosition = (args: ComputePopupPositionArgs): ComputePop | |||
| return position.top + elementSize.height >= viewportSize.height ? 'top' : 'bottom'; | |||
| case 'left': | |||
| return position.left < 0 ? 'right' : 'left'; | |||
| case 'right-aligned-bottom': | |||
| return position.top + elementSize.height >= viewportSize.height ? 'top' : 'right-aligned-bottom'; | |||
There was a problem hiding this comment.
I put this in as more of a placeholder because I'm not sure the exact behavior we want for if this needs to be flipped - Do we want to define a 'right-aligned-top'? and have it flip to the top? If it cuts off on the side, do we want a 'left-aligned-bottom'? etc..
There was a problem hiding this comment.
I would check with Lou! This is a great chance to have a conversation with him about what he thinks makes sense.
src/dataset-builder/ConceptSearch.ts
Outdated
| side: 'right-aligned-bottom', | ||
| content: div({ style: { padding: 16, overflowWrap: 'break-word', width: '30em' } }, [ | ||
| strong(['Concept name:']), | ||
| p({ style: { marginTop: 4, marginBottom: 24 } }, [ |
There was a problem hiding this comment.
Could you define a constant for these styles as opposed to redefining for each p tag?
src/dataset-builder/ConceptSearch.ts
Outdated
| PopupTrigger, | ||
| { | ||
| side: 'right-aligned-bottom', | ||
| content: div({ style: { padding: 16, overflowWrap: 'break-word', width: '30em' } }, [ |
There was a problem hiding this comment.
Nit: In general we prefer rem to em. Would you mind adjusting to using rem?
|
|
|
||
| it('renders column headers defined', async () => { | ||
| // Arrange | ||
| renderSearch(); // might change |
There was a problem hiding this comment.
what does this comment mean?
There was a problem hiding this comment.
Good catch, I had something else there before as a placeholder before figuring out how to set up the test, let me delete that comment
Jira Ticket: https://broadworkbench.atlassian.net/browse/DC-1176
Summary of changes:
What
Testing strategy
Screen.Recording.2024-09-17.at.1.36.52.PM.mov