Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BPM #206

Merged
merged 62 commits into from
Nov 13, 2023
Merged

Add support for BPM #206

merged 62 commits into from
Nov 13, 2023

Conversation

NouemanKHAL
Copy link
Member

What does this PR do?

Adds support for using BPM instead of monit to manage the datadog agent processes in the BOSH release via the property bpm.enabled.
As a side effect, using BPM allows the Process Check to correctly collect both BPM and monit processes.

Description of the Change

  • Add a feature flag bpm.enabled to control whether or not to use BPM.
  • Add a template bpm.yml.erb to generate the BPM config bpm.yml which contains the configuration for the 4 agent processes (datadog-agent, process-agent, trace-agent, system-probe).
  • Add spec properties to the dd-agent job in the form bpm.<PROCESS>.<LIMIT> to give control over each process limits (memory, open_files, processes).

Resources:

Verification Process

Deployed on multiple testing environments (TAS 3.0, TAS 4.0).

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@NouemanKHAL NouemanKHAL added the changelog/Added Added features results into a minor version bump label Sep 28, 2023
@NouemanKHAL NouemanKHAL requested a review from a team as a code owner September 28, 2023 08:20
sarah-witt
sarah-witt previously approved these changes Nov 2, 2023
@NouemanKHAL NouemanKHAL merged commit d901e7d into master Nov 13, 2023
2 checks passed
@NouemanKHAL NouemanKHAL deleted the noueman/migrate-to-bpm branch November 13, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants