Fix trace_agent_ctl deprecated flag in use #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flag is deprecated for new flag
Simon-Wood1980
changed the title
alai97
previously approved these changes
Nov 20, 2023
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
NouemanKHAL
approved these changes
Dec 6, 2023
NouemanKHAL
added
the
changelog/Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
trace_agent_ctl fails to run in monit.
Run command has a depreicated flag for pid
Description of the Change
Update the --pid flag to --pidfile due to deprecation of old flag and process fails.
Alternate Designs
NA
Possible Drawbacks
NA
Verification Process
I have tested this manually on a bosh deployed VM. The monit process loads with the new flag suggested in the help of the command.
Additional Notes
NA
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.