Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kitchen] Add Amazon Linux kitchen tests #13156

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

KSerrania
Copy link
Contributor

@KSerrania KSerrania commented Aug 18, 2022

What does this PR do?

Adds Amazon Linux 2 and Amazon Linux 2022 install script kitchen tests to our suite of install tests.
These tests have to run on EC2, since only AWS provides them.

Motivation

Expand our OS coverage in tests.

Additional Notes

libxcrypt-compat needs to be installed on the Amazon Linux 2022 host before running chef, because chef has a dependency on libcrypt.so.1, which isn't installed by default on the host.

The Amazon Linux tests have to use a pregenerated ssh key (stored in SSM) because the keys autogenerated by the EC2 driver currently do not work. This workaround may be removed once test-kitchen/kitchen-ec2#588 is fixed and the EC2 driver upgraded.

Possible Drawbacks / Trade-offs

n/a

Describe how to test/QA your changes

Amazon Linux kitchen tests pass.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@KSerrania KSerrania added changelog/no-changelog [deprecated] team/agent-platform [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Aug 18, 2022
@KSerrania KSerrania added this to the 7.40.0 milestone Aug 18, 2022
@KSerrania KSerrania marked this pull request as ready for review August 18, 2022 10:30
@KSerrania KSerrania requested a review from a team as a code owner August 18, 2022 10:30
@KSerrania KSerrania merged commit e4ec93c into main Aug 18, 2022
@KSerrania KSerrania deleted the kserrania/add-amazonlinux-kitchen-tests branch August 18, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants