Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --restricted_roles option to Monitors API #809

Merged
merged 13 commits into from
Jan 25, 2024
Merged

Conversation

pierreln-dd
Copy link
Contributor

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR adds the "restricted_roles" argument to the Monitors API endpoint (see https://docs.datadoghq.com/api/latest/monitors/#create-a-monitor)

Description of the Change

Added the argument --restricted_roles to all the necessary parsers in order to be able to create/update/validate monitors with restricted roles

Alternate Designs

Possible Drawbacks

Verification Process

I installed the project locally and performed some local tests against my account. I specifically checked that I could add multiple roles, and checked in my DD account that the roles were properly added.
I also ran the tox integration tests but had a lot of errors that were not from my change.

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@pierreln-dd pierreln-dd added resource/dogshell changelog/Added Added features results into a minor version bump kind/bug Bug related issue severity/minor Minor severity issue labels Dec 26, 2023
@pierreln-dd pierreln-dd requested a review from a team as a code owner December 26, 2023 10:39
datadog/dogshell/monitor.py Outdated Show resolved Hide resolved
datadog/dogshell/monitor.py Outdated Show resolved Hide resolved
@skarimo skarimo merged commit 4dcf1ed into master Jan 25, 2024
11 checks passed
@skarimo skarimo deleted the pierrelndd/MNTS-90348 branch January 25, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump kind/bug Bug related issue resource/dogshell severity/minor Minor severity issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants