-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add buffered_metrics object type #853
Merged
andrewqian2001datadog
merged 13 commits into
add-extended-aggregation
from
add_buffered_metric_object
Sep 10, 2024
Merged
add buffered_metrics object type #853
andrewqian2001datadog
merged 13 commits into
add-extended-aggregation
from
add_buffered_metric_object
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewqian2001datadog
changed the base branch from
master
to
add-extended-aggregation
September 4, 2024 18:58
…ogpy into add_buffered_metric_object
andrewqian2001datadog
added
the
changelog/no-changelog
Changes don't appear in changelog
label
Sep 4, 2024
rayz
requested changes
Sep 6, 2024
rayz
reviewed
Sep 6, 2024
rayz
reviewed
Sep 6, 2024
rayz
approved these changes
Sep 10, 2024
andrewqian2001datadog
merged commit Sep 10, 2024
c171911
into
add-extended-aggregation
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds BufferedMetric object to allow for extended aggregation (Distribution, Histogram, Timing metrics)
Based on off existing Go code
Description of the Change
Adds a
buffered_metrics.py
class that has all the properties that Distribution, Histogram and Timing metrics requireVerification Process
Added unit tests matching the existing tests
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.