contrib/log/slog: implement handler.WithAttrs #2839
Draft
+12
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
implement contrib/log/slog.handler.WithAttrs
Motivation
resolve #2838
Note
In the issue, I mentioned that the handler is replaced by Logger.WithGroup call as well. But I'm not sure if it is fine to implement handler.WithGroup in this case.
If you implement logger.WithGruop like
the logger will produce the log with grouped dd attributes.
But I think it is not what datadog expected.
I would like some advice on this.
Reviewer's Checklist
Unsure? Have a question? Request a review!