Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error stack in span's resource when a AMQP connection error occurs #2069

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Fix error stack in span's resource when a AMQP connection error occurs #2069

merged 5 commits into from
Jun 8, 2023

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented May 22, 2023 •
edited
Loading

Description

Bugfix #1840. The call to setGenericTags was made using the exception as the resource detail in some cases. It will also retrieve the protocol version in the prehook (instead of the posthook) of the AbstractConnection::_construct method, since it wouldn't have been otherwise retrieved when a connection error would occur.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@PROFeNoM PROFeNoM added 🐛 bug Something isn't working tracing labels May 22, 2023
@PROFeNoM PROFeNoM self-assigned this May 22, 2023
@PROFeNoM PROFeNoM requested a review from a team as a code owner May 22, 2023 14:06
@PROFeNoM PROFeNoM marked this pull request as draft May 22, 2023 14:06
@PROFeNoM PROFeNoM marked this pull request as ready for review May 22, 2023 14:42
@PROFeNoM PROFeNoM changed the title Fix parameter order in some method call in the AMQP integration Fix crash when a AMQP connection error occurs May 22, 2023
bwoebi
bwoebi approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good :-)

@PROFeNoM PROFeNoM changed the title Fix crash when a AMQP connection error occurs Fix error stack in span's resource when a AMQP connection error occurs May 23, 2023
@bwoebi bwoebi added this to the 0.88.0 milestone Jun 7, 2023
@PROFeNoM PROFeNoM merged commit 2c0e51e into master Jun 8, 2023
@PROFeNoM PROFeNoM deleted the alex/fix/amqp-parameters-order branch June 8, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

@PROFeNoM PROFeNoM

Labels
🐛 bug Something isn't working tracing
Projects
None yet
Milestone
0.88.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PROFeNoM @bwoebi