Remove Symfony Command Hook After Execution #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PROFeNoM
force-pushed
the
alex/issue/gh2427-bis
branch
from
d52d550
to
08e27d9
Compare
PROFeNoM
changed the title
bwoebi
reviewed
Jan 29, 2024
|
|
||
| $symfonyCommandsIntegrated[$scope] = true; | ||
|
|
||
| \DDTrace\trace_method($scope, 'run', [ |
There was a problem hiding this comment.
I assume this was an artifact of pre-historical times when we had no support for abstract method hooks?
At a glance this fix looks pretty good to me.
bwoebi
approved these changes
Jan 29, 2024
BenchmarksBenchmark execution time: 2024-01-29 13:18:43 Comparing candidate commit 210f0c0 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 49 unstable metrics. scenario:PHPRedisBench/benchRedisBaseline
|
PROFeNoM
force-pushed
the
alex/issue/gh2427-bis
branch
from
08e27d9
to
210f0c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2427
This PR should have been included with #2436
TL;DR of the issue:
The current implementation of the command hooks adds a hook to a
<scope>::runif it wasn't already added. This could, theoretically, lead to multiple hooks added when considering numerous inheritors.About the fix: Considering that in the previous version the hook was made on
Symfony\Component\Console\Command\Command::__construct, it means that$scopefundamentally represents aSymfony\Component\Console\Command\Commandinstance. From this, the new implementation directly hooksSymfony\Component\Console\Command\Command::runinstead of adding a seemingly unnecessary intermediary step.Reviewer checklist