Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeIgniter 3 Compatibility #2515

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Conversation

PROFeNoM
Copy link
Contributor

Description

Add the CodeIgniter 3 test suite, and allow the integration to be used with this version since it is seemingly compatible with it.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Feb 12, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2024

Benchmarks

Benchmark execution time: 2024-04-02 13:24:59

Comparing candidate commit 0968e64 in PR branch alex/feat/codeigniter-testsuite with baseline commit e670e76 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 180 metrics, 0 unstable metrics.

scenario:ContextPropagationBench/benchInject64Bit-opcache

  • 🟥 execution_time [+147.578ns; +806.422ns] or [+2.048%; +11.189%]

scenario:SpanBench/benchOpenTelemetryInteroperability-opcache

  • 🟥 execution_time [+17.686µs; +45.153µs] or [+2.491%; +6.360%]

@PROFeNoM
Copy link
Contributor Author

On-hold. See bcit-ci/CodeIgniter#6267

@PROFeNoM PROFeNoM force-pushed the alex/feat/codeigniter-testsuite branch from c52dec0 to e9fbe6c Compare April 2, 2024 09:14
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Merging #2515 (0968e64) into master (e670e76) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2515   +/-   ##
=========================================
  Coverage     76.53%   76.53%           
- Complexity     2607     2609    +2     
=========================================
  Files           217      217           
  Lines         23318    23318           
=========================================
  Hits          17846    17846           
  Misses         5472     5472           
Flag Coverage Δ
tracer-extension 78.70% <ø> (ø)
tracer-php 73.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...grations/CodeIgniter/V2/CodeIgniterIntegration.php 50.64% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e670e76...0968e64. Read the comment docs.

@PROFeNoM PROFeNoM force-pushed the alex/feat/codeigniter-testsuite branch from 6a5c69e to 6b22733 Compare April 2, 2024 12:47
@PROFeNoM PROFeNoM marked this pull request as ready for review April 3, 2024 12:51
@PROFeNoM PROFeNoM requested a review from a team as a code owner April 3, 2024 12:51
@PROFeNoM PROFeNoM merged commit 633c5ad into master Apr 4, 2024
554 of 557 checks passed
@PROFeNoM PROFeNoM deleted the alex/feat/codeigniter-testsuite branch April 4, 2024 06:57
@github-actions github-actions bot added this to the 0.100.0 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants