Make ddtrace_disable a true global to avoid crashes in ZTS with unsupported SAPI/extensions #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/true-global-disable
branch
from
f29017c
to
a3caa32
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2545 +/- ##
============================================
+ Coverage 76.55% 79.49% +2.94%
+ Complexity 267 216 -51
============================================
Files 138 103 -35
Lines 17457 12740 -4717
Branches 976 0 -976
============================================
- Hits 13364 10128 -3236
+ Misses 3573 2612 -961
+ Partials 520 0 -520
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 47 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…ported SAPI/extensions Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/true-global-disable
branch
from
a3caa32
to
4d5be5b
Compare
BenchmarksBenchmark execution time: 2024-02-29 11:28:36 Comparing candidate commit 4d5be5b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 182 metrics, 0 unstable metrics. |
realFlowControl
approved these changes
Feb 29, 2024
bwoebi
added a commit
that referenced
this pull request
Mar 4, 2024
…ported SAPI/extensions (#2545) Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple bugfix, found with frankenphp zts.
Reviewer checklist