Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fibers with tracer disabled #2576

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix fibers with tracer disabled #2576

merged 1 commit into from
Mar 20, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Mar 19, 2024

Description

Fibers were crashing when using ddtrace.disable=1.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi requested a review from a team as a code owner March 19, 2024 11:51
@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2024

Benchmarks

Benchmark execution time: 2024-03-19 12:21:00

Comparing candidate commit 87effa0 in PR branch bob/fix-fibers with baseline commit 91227e5 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 179 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+15.779µs; +16.391µs] or [+9.108%; +9.461%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+14.299µs; +16.086µs] or [+5.310%; +5.974%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+15.079µs; +17.317µs] or [+5.178%; +5.946%]

@codecov-commenter
Copy link

Codecov Report

Merging #2576 (87effa0) into master (91227e5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2576   +/-   ##
=========================================
  Coverage     75.77%   75.77%           
  Complexity     2563     2563           
=========================================
  Files           241      241           
  Lines         27024    27024           
  Branches        976      976           
=========================================
  Hits          20478    20478           
  Misses         6026     6026           
  Partials        520      520           
Flag Coverage Δ
appsec-extension 69.13% <ø> (ø)
tracer-extension 78.70% <100.00%> (ø)
tracer-php 74.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/ddtrace.c 73.13% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91227e5...87effa0. Read the comment docs.

@bwoebi bwoebi merged commit 5e73d78 into master Mar 20, 2024
579 of 607 checks passed
@bwoebi bwoebi deleted the bob/fix-fibers branch March 20, 2024 13:27
@github-actions github-actions bot added this to the 0.99.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants