Fix #2563: ddtrace overrides php error log permissions #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now only change log permissions on log creation. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
BenchmarksBenchmark execution time: 2024-03-20 15:02:20 Comparing candidate commit 669b71f in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 181 metrics, 0 unstable metrics. scenario:SamplingRuleMatchingBench/benchRegexMatching4
|
PROFeNoM
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We now only change log permissions on log creation.
Not sure how to do a phpt test for that. The file must already exist before the test runs, so a bit of a catch 22.
Reviewer checklist