Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Configuration classes from API #2596

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Mar 26, 2024

Description

They're nowhere used internally (anymore). Avoid having multiple APIs: dd_trace_env_config() is enough.

Please consider whether this makes sense.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@bwoebi bwoebi requested a review from a team as a code owner March 26, 2024 15:45
@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2024

Benchmarks

Benchmark execution time: 2024-03-27 12:17:31

Comparing candidate commit c0cda03 in PR branch bob/drop-api-config with baseline commit 530e4cd in branch ddtrace-1.0.0.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟥 execution_time [+11.093µs; +15.907µs] or [+3.258%; +4.672%]

They're nowhere used internally (anymore). Avoid having multiple APIs: dd_trace_env_config() is enough.
We generally accept a double internally (e.g. start_span), so this won't be needed for users either.
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Merging #2596 (c0cda03) into ddtrace-1.0.0 (530e4cd) will increase coverage by 0.46%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             ddtrace-1.0.0    #2596      +/-   ##
===================================================
+ Coverage            77.51%   77.98%   +0.46%     
+ Complexity            2257     2181      -76     
===================================================
  Files                  227      224       -3     
  Lines                25840    25676     -164     
  Branches               976      976              
===================================================
- Hits                 20030    20023       -7     
+ Misses                5290     5133     -157     
  Partials               520      520              
Flag Coverage Δ
appsec-extension 69.13% <ø> (ø)
tracer-extension 78.46% <ø> (ø)
tracer-php 81.23% <ø> (+1.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/api/Data/Span.php 65.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 530e4cd...c0cda03. Read the comment docs.

Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These removals look good to be as seemingly not used internally and not customer-facing.

FYI, this test is failing - I don't think it's related with this PR though (or maybe a re-run is enough, idk).

@bwoebi bwoebi merged commit 1fab516 into ddtrace-1.0.0 Mar 27, 2024
641 of 650 checks passed
@bwoebi bwoebi deleted the bob/drop-api-config branch March 27, 2024 14:42
@bwoebi bwoebi added this to the 0.100.0 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants