Clean Integration configuration #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-04-15 12:38:57 Comparing candidate commit 1694553 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics. scenario:TraceSerializationBench/benchSerializeTrace
|
iamluc
reviewed
Apr 12, 2024
| @@ -454,7 +446,7 @@ public function setGenericTags( | |||
| $span->meta[Tag::MQ_PROTOCOL_VERSION] = $this->protocolVersion; | |||
|
|
|||
| if ($exception) { | |||
| $this->setError($span, $exception); | |||
| $span->exception = $exception; | |||
There was a problem hiding this comment.
Coding style: there is an extra space for every $this->setError() conversion
bwoebi
force-pushed
the
bob/clean-integration-config
branch
from
569c575
to
7296383
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2598 +/- ##
============================================
+ Coverage 77.78% 79.35% +1.56%
+ Complexity 2240 2195 -45
============================================
Files 228 199 -29
Lines 26036 21942 -4094
Branches 986 0 -986
============================================
- Hits 20253 17412 -2841
+ Misses 5257 4530 -727
+ Partials 526 0 -526
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bwoebi
force-pushed
the
bob/clean-integration-config
branch
from
7296383
to
17cf76d
Compare
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. If you need to update snapshots, please refer to CONTRIBUTING.md 1 occurrences of : - "parent_id": 14729891649013051183
+ "parent_id": 18234754190136783259
1 occurrences of : - "runtime-id": "1b0e863a-39eb-40f0-8723-5446bc1f418b"
+ "_dd.p.tid": "66196c9000000000"
+ "runtime-id": "c8243154-ab37-45b8-8195-3a5c13730796"
1 occurrences of : - "error.stack": "#0 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/Routing/AccessAwareRouter.php(90): Drupal\\Core\\Routing\\Router->matchRequest()\n#1 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/EventListener/RouterListener.php(105): Drupal\\Core\\Routing\\AccessAwareRouter->matchRequest()\n#2 [internal function]: Symfony\\Component\\HttpKernel\\EventListener\\RouterListener->onKernelRequest()\n#3 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func()\n#4 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/HttpKernel.php(158): Drupal\\Component\\EventDispatcher\\ContainerAwareEventDispatcher->dispatch()\n#5 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\\Component\\HttpKernel\\HttpKernel->handleRaw()\n#6 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\\Component\\HttpKernel\\HttpKernel->handle()\n#7 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\\Core\\StackMiddleware\\Session->handle()\n#8 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\\Core\\StackMiddleware\\KernelPreHandle->handle()\n#9 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\\Core\\StackMiddleware\\ReverseProxyMiddleware->handle()\n#10 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\\Core\\StackMiddleware\\NegotiationMiddleware->handle()\n#11 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\\Core\\StackMiddleware\\StackedHttpKernel->handle()\n#12 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/index.php(19): Drupal\\Core\\DrupalKernel->handle()\n#13 {main}\n\nNext Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: No route found for \"GET http://localhost:9999/does_not_exist\" in /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/EventListener/RouterListener.php:127\nStack trace:\n#0 [internal function]: Symfony\\Component\\HttpKernel\\EventListener\\RouterListener->onKernelRequest()\n#1 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func()\n#2 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/HttpKernel.php(158): Drupal\\Component\\EventDispatcher\\ContainerAwareEventDispatcher->dispatch()\n#3 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\\Component\\HttpKernel\\HttpKernel->handleRaw()\n#4 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\\Component\\HttpKernel\\HttpKernel->handle()\n#5 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\\Core\\StackMiddleware\\Session->handle()\n#6 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\\Core\\StackMiddleware\\KernelPreHandle->handle()\n#7 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\\Core\\StackMiddleware\\ReverseProxyMiddleware->handle()\n#8 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\\Core\\StackMiddleware\\NegotiationMiddleware->handle()\n#9 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\\Core\\StackMiddleware\\StackedHttpKernel->handle()\n#10 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/index.php(19): Drupal\\Core\\DrupalKernel->handle()\n#11 {main}"
+ "_dd1.sr.eausr": 1.0
+ "error.stack": "#0 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/Routing/AccessAwareRouter.php(90): Drupal\\Core\\Routing\\Router->matchRequest()\n#1 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/EventListener/RouterListener.php(105): Drupal\\Core\\Routing\\AccessAwareRouter->matchRequest()\n#2 [internal function]: Symfony\\Component\\HttpKernel\\EventListener\\RouterListener->onKernelRequest()\n#3 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func()\n#4 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/HttpKernel.php(157): Drupal\\Component\\EventDispatcher\\ContainerAwareEventDispatcher->dispatch()\n#5 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\\Component\\HttpKernel\\HttpKernel->handleRaw()\n#6 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\\Component\\HttpKernel\\HttpKernel->handle()\n#7 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\\Core\\StackMiddleware\\Session->handle()\n#8 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\\Core\\StackMiddleware\\KernelPreHandle->handle()\n#9 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\\Core\\StackMiddleware\\ReverseProxyMiddleware->handle()\n#10 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\\Core\\StackMiddleware\\NegotiationMiddleware->handle()\n#11 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\\Core\\StackMiddleware\\StackedHttpKernel->handle()\n#12 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/index.php(19): Drupal\\Core\\DrupalKernel->handle()\n#13 {main}\n\nNext Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: No route found for \"GET http://localhost:9999/does_not_exist\" in /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/EventListener/RouterListener.php:127\nStack trace:\n#0 [internal function]: Symfony\\Component\\HttpKernel\\EventListener\\RouterListener->onKernelRequest()\n#1 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func()\n#2 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/HttpKernel.php(157): Drupal\\Component\\EventDispatcher\\ContainerAwareEventDispatcher->dispatch()\n#3 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\\Component\\HttpKernel\\HttpKernel->handleRaw()\n#4 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\\Component\\HttpKernel\\HttpKernel->handle()\n#5 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\\Core\\StackMiddleware\\Session->handle()\n#6 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\\Core\\StackMiddleware\\KernelPreHandle->handle()\n#7 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\\Core\\StackMiddleware\\ReverseProxyMiddleware->handle()\n#8 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\\Core\\StackMiddleware\\NegotiationMiddleware->handle()\n#9 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\\Core\\StackMiddleware\\StackedHttpKernel->handle()\n#10 /home/circleci/datadog/tests/Frameworks/Drupal/Version_10_1/index.php(19): Drupal\\Core\\DrupalKernel->handle()\n#11 {main}"
1 occurrences of : - "parent_id": 4458984828784253894
+ "parent_id": 1011645146387165012
1 occurrences of : - "runtime-id": "9909a648-1886-44d2-b341-b1ddc0f62f34"
+ "_dd.p.tid": "66196c8f00000000"
+ "runtime-id": "c8243154-ab37-45b8-8195-3a5c13730796"
1 occurrences of : - "parent_id": 16602002948505053039
+ "_dd1.sr.eausr": 1.0
+ "parent_id": 15899644691888394517
1 occurrences of : - "runtime-id": "cecb7d5b-eb5a-49f8-8374-29dce2d6fce6"
+ "_dd.p.tid": "66196c8d00000000"
+ "runtime-id": "c8243154-ab37-45b8-8195-3a5c13730796"
1 occurrences of : - "parent_id": 8612363250016351856
+ "_dd1.sr.eausr": 1.0
+ "parent_id": 8128476922872635117
1 occurrences of : - "runtime-id": "692423cd-81b3-449e-a67e-43150df99f74"
+ "_dd.p.tid": "66196d5a00000000"
+ "runtime-id": "1fd18b54-8b5e-4ff6-8aa2-cd7356ba5bf6"
1 occurrences of : - "parent_id": 10065802695341457060
+ "_dd1.sr.eausr": 1.0
+ "parent_id": 6944474013131017888
1 occurrences of : - "runtime-id": "692423cd-81b3-449e-a67e-43150df99f74"
+ "_dd.p.tid": "66196d5900000000"
+ "runtime-id": "1fd18b54-8b5e-4ff6-8aa2-cd7356ba5bf6"
1 occurrences of : - "parent_id": 3272765232554916325
+ "_dd1.sr.eausr": 1.0
+ "parent_id": 12358919399676608040
1 occurrences of : - "runtime-id": "692423cd-81b3-449e-a67e-43150df99f74"
+ "_dd.p.tid": "66196d5700000000"
+ "runtime-id": "1fd18b54-8b5e-4ff6-8aa2-cd7356ba5bf6"
1 occurrences of : - "parent_id": 3252206533936179831
+ "_dd1.sr.eausr": 1.0
+ "parent_id": 3103709691901046446
1 occurrences of : - "runtime-id": "7a7b1e1f-04e8-41dc-82bd-81f24ef6e0a4"
+ "_dd.p.tid": "66196d8700000000"
+ "runtime-id": "0c81a719-e9e9-42f6-b426-92236791f086"
1 occurrences of : - "parent_id": 4278622301037098128
+ "_dd1.sr.eausr": 1.0
+ "parent_id": 13887724427007327375
1 occurrences of : - "runtime-id": "3afe4427-fcda-4ade-bdc5-572a8c5f8b12"
+ "_dd.p.tid": "66196d8700000000"
+ "runtime-id": "0c81a719-e9e9-42f6-b426-92236791f086"
1 occurrences of : - "parent_id": 17928482264370609219
+ "_dd1.sr.eausr": 1.0
+ "parent_id": 9047586870474301699
1 occurrences of : - "runtime-id": "7a7b1e1f-04e8-41dc-82bd-81f24ef6e0a4"
+ "_dd.p.tid": "66196d8500000000"
+ "runtime-id": "0c81a719-e9e9-42f6-b426-92236791f086"
|
bwoebi
force-pushed
the
bob/clean-integration-config
branch
5 times, most recently
from
1694553
to
49c8faa
Compare
Also avoid the extra Util\Common class and just stuff it into the global Integration.
bwoebi
force-pushed
the
bob/clean-integration-config
branch
from
49c8faa
to
742421d
Compare
github-actions
bot
added
profiling
morrisonlevi
pushed a commit
that referenced
this pull request
Apr 16, 2024
Also avoid the extra Util\Common class and just stuff it into the global Integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also avoid the extra Util\Common class and just stuff it into the global Integration.
Simplifies the code a bit I hope.
Reviewer checklist