Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Laravel appsec login success event more accurate #2600

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

estringana
Copy link
Contributor

@estringana estringana commented Mar 28, 2024

Description

It has been reported that the previous approach to trigger successful logins is not accurate. This results on some endpoints reporting successful login events on every request instead of just when a user gets logged in into the system. This PR attach the event to the event provided by Laravel

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

Codecov Report

Merging #2600 (fc98f13) into master (3d4313f) will decrease coverage by 12.14%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2600       +/-   ##
=============================================
- Coverage     76.90%   64.76%   -12.14%     
  Complexity     2564     2564               
=============================================
  Files           215      215               
  Lines         23095    23095               
=============================================
- Hits          17761    14958     -2803     
- Misses         5334     8137     +2803     
Flag Coverage Δ
tracer-extension 78.66% <ø> (+<0.01%) ⬆️
tracer-php 47.50% <0.00%> (-27.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ations/Integrations/Laravel/LaravelIntegration.php 0.00% <0.00%> (-81.91%) ⬇️

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4313f...fc98f13. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Mar 28, 2024

Benchmarks

Benchmark execution time: 2024-03-28 09:41:16

Comparing candidate commit fc98f13 in PR branch estringana/improve-login-success-laravel-event with baseline commit 3d4313f in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 181 metrics, 0 unstable metrics.

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-13.487µs; -10.413µs] or [-7.245%; -5.594%]

@estringana estringana marked this pull request as ready for review March 28, 2024 10:57
@estringana estringana requested a review from a team as a code owner March 28, 2024 10:57
@estringana estringana requested a review from Anilm3 March 28, 2024 10:57
Copy link
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🛥️

@estringana estringana merged commit c993b6a into master Mar 28, 2024
554 of 557 checks passed
@estringana estringana deleted the estringana/improve-login-success-laravel-event branch March 28, 2024 11:35
@github-actions github-actions bot added this to the 0.99.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants