Fix asan leak on fork in PHP 8.2 buster container #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around php/php-src#12298 and the related memory leaks. This is necessary with the relatively old version of glibc we are building against. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2608 +/- ##
=============================================
- Coverage 75.47% 64.39% -11.09%
Complexity 2607 2607
=============================================
Files 243 217 -26
Lines 27317 23318 -3999
Branches 985 0 -985
=============================================
- Hits 20618 15015 -5603
- Misses 6174 8303 +2129
+ Partials 525 0 -525
Flags with carried forward coverage won't be shown. Click here to find out more. see 46 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
iamluc
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Works around php/php-src#12298 and the related memory leaks. This is necessary with the relatively old version of glibc we are building against.
The patch with free() is also specific to the glibc the buster container uses.
Reviewer checklist