feat: Add --ini and --extension-dir installation option
#2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
reviewed
Apr 12, 2024
| --enable-appsec Enable the application security monitoring module. | ||
| --enable-profiling Enable the profiling module. | ||
| --enable-profiling Enable the profiling module. |
There was a problem hiding this comment.
Interesting space you've added here? :-)
There was a problem hiding this comment.
Interesting, indeed.
PROFeNoM
commented
Apr 12, 2024
PROFeNoM
force-pushed
the
alex/feat/ini-setup
branch
from
ed6c4d5
to
deabfc3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2620 +/- ##
============================================
+ Coverage 77.64% 79.21% +1.57%
Complexity 2226 2226
============================================
Files 226 200 -26
Lines 25942 21942 -4000
Branches 986 0 -986
============================================
- Hits 20142 17382 -2760
+ Misses 5274 4560 -714
+ Partials 526 0 -526
Flags with carried forward coverage won't be shown. Click here to find out more. see 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bwoebi
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FRAPMS-4418
The setup script now has two new installation options:
--iniand--extension-dir. This should allow customers more flexibility regarding which INI file should be used and where the.sofiles will be copied.Reviewer checklist