-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stats reporting for sidecar and telemetry #2621
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2621 +/- ##
============================================
- Coverage 77.64% 77.62% -0.02%
Complexity 2226 2226
============================================
Files 226 226
Lines 25942 25948 +6
Branches 986 986
============================================
+ Hits 20142 20143 +1
- Misses 5274 5279 +5
Partials 526 526
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
BenchmarksBenchmark execution time: 2024-04-15 15:06:47 Comparing candidate commit 7232505 in PR branch Found 5 performance improvements and 3 performance regressions! Performance is the same for 170 metrics, 0 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:PDOBench/benchPDOBaseline
scenario:PDOBench/benchPDOBaseline-opcache
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverhead-opcache
scenario:PDOBench/benchPDOOverheadWithDBM-opcache
scenario:TraceSerializationBench/benchSerializeTrace
|
9be20cb
to
7232505
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
7232505
to
ff14950
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
# DD_TRACE_CLI_ENABLED=1 php -d datadog.trace.log_level=trace -d datadog.trace.log_file=/tmp/sidelog -r 'var_dump(dd_trace_internal_fn("stats_sidecar"));'
outputs:
string(979) "{"trace_flusher":{"agent_config_allocated_shm":0,"agent_config_writers":0,"agent_configs_last_used_entries":0,"send_data_size":0},"sessions":5,"session_counter_size":5,"runtimes":4,"apps":4,"active_apps":0,"enqueued_apps":0,"enqueued_telemetry_data":{"dependencies_stored":0,"dependencies_unflushed":0,"configurations_stored":0,"configurations_unflushed":0,"integrations_stored":0,"integrations_unflushed":0,"metrics":0,"points":0,"actions":0,"computed_dependencies":0},"telemetry_metrics_contexts":4,"telemetry_worker":{"dependencies_stored":660,"dependencies_unflushed":660,"configurations_stored":832,"configurations_unflushed":0,"integrations_stored":10,"integrations_unflushed":10,"logs":0,"metric_contexts":4,"metric_buckets":{"buckets":8,"series":0,"series_points":0,"distributions":0,"distributions_points":0}},"telemetry_worker_errors":0,"log_writer":{"elements":2,"live_counters":2,"pending_removal":0},"log_filter":{"elements":2,"live_counters":2,"pending_removal":0}}"
Giving clear helpful debugging information for sidecar memory leaks. (upstream PR DataDog/libdatadog#392)