-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use app name as service for laravel queue #2643
Conversation
BenchmarksBenchmark execution time: 2024-04-29 08:44:48 Comparing candidate commit 21a31ce in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics. scenario:TraceFlushBench/benchFlushTrace-opcache
scenario:TraceSerializationBench/benchSerializeTrace
|
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. If you need to update snapshots, please refer to CONTRIBUTING.md 1 occurrences of : - "service": "laravelqueue"
+ "service": "laravel_queue_test"
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2643 +/- ##
=========================================
Coverage 79.35% 79.35%
Complexity 2198 2198
=========================================
Files 199 199
Lines 21959 21959
=========================================
Hits 17426 17426
Misses 4533 4533
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
8f932fa
to
21a31ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 😃
Description
Fixes laravel queue integration issue with service naming described in #2637
Reviewer checklist