Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app name as service for laravel queue #2643

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

pablomartinezbernardo
Copy link
Contributor

@pablomartinezbernardo pablomartinezbernardo commented Apr 25, 2024

Description

Fixes laravel queue integration issue with service naming described in #2637

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@pr-commenter
Copy link

pr-commenter bot commented Apr 25, 2024

Benchmarks

Benchmark execution time: 2024-04-29 08:44:48

Comparing candidate commit 21a31ce in PR branch pmartinez/laravel-service with baseline commit 94c7e3a in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:TraceFlushBench/benchFlushTrace-opcache

  • 🟥 mem_peak [+232.592KB; +232.592KB] or [+12.483%; +12.483%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟥 execution_time [+3.745µs; +7.455µs] or [+2.084%; +4.147%]

Copy link

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

If you need to update snapshots, please refer to CONTRIBUTING.md

1 occurrences of :

- "service": "laravelqueue"
+ "service": "laravel_queue_test"

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.35%. Comparing base (94c7e3a) to head (21a31ce).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2643   +/-   ##
=========================================
  Coverage     79.35%   79.35%           
  Complexity     2198     2198           
=========================================
  Files           199      199           
  Lines         21959    21959           
=========================================
  Hits          17426    17426           
  Misses         4533     4533           
Flag Coverage Δ
tracer-extension 78.49% <ø> (ø)
tracer-php 80.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...egrations/LaravelQueue/LaravelQueueIntegration.php 95.97% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c7e3a...21a31ce. Read the comment docs.

@pablomartinezbernardo pablomartinezbernardo changed the title Get app name Use app name as service for laravel queue Apr 26, 2024
@pablomartinezbernardo pablomartinezbernardo marked this pull request as ready for review April 26, 2024 13:02
@pablomartinezbernardo pablomartinezbernardo requested a review from a team as a code owner April 26, 2024 13:02
Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😃

@pablomartinezbernardo pablomartinezbernardo merged commit 54b48e5 into master Apr 29, 2024
550 of 556 checks passed
@pablomartinezbernardo pablomartinezbernardo deleted the pmartinez/laravel-service branch April 29, 2024 15:00
@bwoebi bwoebi added this to the 1.0.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working cat:integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants