-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
w3c(phase 3): ensure tracecontext headers always take precedence #2667
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2667 +/- ##
=========================================
Coverage 77.78% 77.79%
Complexity 2223 2223
=========================================
Files 226 226
Lines 26347 26357 +10
Branches 988 988
=========================================
+ Hits 20495 20505 +10
Misses 5326 5326
Partials 526 526
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
fa5b378
to
cc73685
Compare
…ng spans fix condition Update ext/distributed_tracing_headers.c
cc73685
to
870567c
Compare
BenchmarksBenchmark execution time: 2024-05-31 21:20:05 Comparing candidate commit 17dfb2c in PR branch Found 3 performance improvements and 1 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics. scenario:EmptyFileBench/benchEmptyFileBaseline-opcache
scenario:PDOBench/benchPDOBaseline
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverheadWithDBM
|
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
tests/ext/distributed_tracing/distributed_trace_conflicting_span_ids.phpt
Outdated
Show resolved
Hide resolved
tests/ext/distributed_tracing/distributed_trace_conflicting_span_ids.phpt
Outdated
Show resolved
Hide resolved
b639b8c
to
ac29ce9
Compare
2179cec
to
bf9e240
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now :-)
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Description
Ensures when trace headers with the same trace_id but different span_ids are received by an application the tracecontext headers are treated as the source of truth.
The traceparent header will be used to set the parent_id
If the conflicting trace information was extracted from datadog headers, the span_id from the datadog headers will be stored in the _dd.parent_id parent_id tag.
All other propagation styles are third class citizens. If they conflict with tracecontext headers their span_ids will be overwritten.
This behavior will be validated by the following system-tests: DataDog/system-tests#2385
Reviewer checklist