-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sidecar by default on PHP 8.3 #2680
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
dcd29c1
Enable sidecar by default, only when telemetry is enabled
pierotibou 4194c49
Manually set sidecar config to false
bwoebi f9dc45f
minor comments in the tests
pierotibou b41062a
add a test to make sure sidecar is enabled by default in 8.3
pierotibou 6a5ea16
Delay bgs initialization until sidecar sender status is finalized
bwoebi fa95c12
Fix crash
bwoebi 05307d2
Add telemetry for telemetry disabled
bwoebi f8d1f1b
Fix mem leak
bwoebi 34fe63f
Hack to massage sidecar v0.7 into what is expected by tests
bantonsson 63202de
Fix telemetry path
bwoebi 58845c9
More test stability
bwoebi a55c362
Fix header name
iamluc d88c7fc
Update libdatadog
bwoebi 67135e5
Test fixes
bwoebi 8079e32
In the agent sampling test, telemetry conflicts with sidecar
bwoebi 017a3d2
Avoid parseMultipleRequestsFromDumpedData with sidecar
bwoebi a0edcc0
Skip valgrind test
bwoebi 1085733
Turn sidecar sender off in valgrind tests because of false positives
bwoebi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule libdatadog
updated
5 files
+1 −0 | data-pipeline/src/trace_exporter.rs | |
+6 −2 | sidecar/src/service/sidecar_server.rs | |
+1 −0 | trace-mini-agent/src/trace_processor.rs | |
+2 −1 | trace-utils/Cargo.toml | |
+62 −6 | trace-utils/src/trace_utils.rs |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code paths are just to complicated for my brain, but why is it safe to move this code to
dd_activate_once
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Background sender thread is only actually needed once spans may actually be flushed. And that never happens before dd_activate_once.