Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a correct size hint to the sidecar trace flusher #2686

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented May 31, 2024

Also, initial stack size is a low number. Also the wrong number, generally. Instead, we'll flush the traces in the sidecar when a significant percentage of the max payload size is reached.

@bwoebi bwoebi requested review from a team as code owners May 31, 2024 14:49
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.84%. Comparing base (44945bb) to head (1485476).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2686      +/-   ##
============================================
+ Coverage     77.79%   77.84%   +0.04%     
  Complexity     2223     2223              
============================================
  Files           226      226              
  Lines         26357    26357              
  Branches        988      988              
============================================
+ Hits          20505    20517      +12     
+ Misses         5326     5314      -12     
  Partials        526      526              
Flag Coverage Δ
appsec-extension 69.13% <ø> (ø)
tracer-extension 78.66% <50.00%> (ø)
tracer-php 80.46% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/sidecar.c 88.18% <100.00%> (ø)
ext/auto_flush.c 56.17% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44945bb...1485476. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented May 31, 2024

Benchmarks

Benchmark execution time: 2024-05-31 23:52:54

Comparing candidate commit 1485476 in PR branch bob/fix-trace-flush-size with baseline commit 44945bb in branch master.

Found 6 performance improvements and 0 performance regressions! Performance is the same for 172 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟩 execution_time [-607.258µs; -429.842µs] or [-12.930%; -9.153%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟩 execution_time [-587.636µs; -459.084µs] or [-12.144%; -9.488%]

scenario:LaravelBench/benchLaravelOverhead

  • 🟩 execution_time [-564.463µs; -467.457µs] or [-11.499%; -9.523%]

scenario:LaravelBench/benchLaravelOverhead-opcache

  • 🟩 execution_time [-584.255µs; -485.725µs] or [-11.608%; -9.651%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟩 execution_time [-560.372µs; -508.748µs] or [-5.444%; -4.942%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟩 execution_time [-485.129µs; -421.691µs] or [-4.661%; -4.052%]

@bwoebi bwoebi force-pushed the bob/fix-trace-flush-size branch 4 times, most recently from 632f794 to 2b5bcd4 Compare May 31, 2024 21:41
Also, initial stack size is a low number. Also the wrong number, generally.
Instead, we'll flush the traces in the sidecar when a significant percentage of the max payload size is reached.

Then, make sidecar tests much less flaky.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi merged commit 7557b8a into master Jun 1, 2024
586 of 606 checks passed
@bwoebi bwoebi deleted the bob/fix-trace-flush-size branch June 1, 2024 00:13
@github-actions github-actions bot added this to the 1.1.0 milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants