Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(profiling): upgrade libdatadog to v10 #2697

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

morrisonlevi
Copy link
Collaborator

PROF-9125

Description

This shrinks our memory footprint. It also reduces our CPU (but just a smidge, not a big change).

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi added cat:performance profiling Relates to the Continuous Profiler labels Jun 7, 2024
@morrisonlevi morrisonlevi added this to the 1.1.0 milestone Jun 7, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 7, 2024

Benchmarks

Benchmark execution time: 2024-06-07 16:00:09

Comparing candidate commit 3e345e7 in PR branch levi/libdatadog-v10 with baseline commit f8c9e42 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.32%. Comparing base (f8c9e42) to head (3e345e7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2697      +/-   ##
============================================
+ Coverage     77.78%   79.32%   +1.54%     
  Complexity     2223     2223              
============================================
  Files           227      201      -26     
  Lines         26531    22514    -4017     
  Branches        988        0     -988     
============================================
- Hits          20637    17860    -2777     
+ Misses         5368     4654     -714     
+ Partials        526        0     -526     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.63% <ø> (ø)
tracer-php 80.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c9e42...3e345e7. Read the comment docs.

@github-actions github-actions bot removed this from the 1.1.0 milestone Jun 7, 2024
@morrisonlevi morrisonlevi marked this pull request as ready for review June 7, 2024 15:46
@morrisonlevi morrisonlevi requested review from a team as code owners June 7, 2024 15:46
This shrinks our memory footprint and reduces our CPU (but just a
smidge, not a big change).
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks stable :-)

@morrisonlevi morrisonlevi merged commit 4f9928d into master Jun 7, 2024
582 of 588 checks passed
@morrisonlevi morrisonlevi deleted the levi/libdatadog-v10 branch June 7, 2024 17:42
@github-actions github-actions bot added this to the 1.1.0 milestone Jun 7, 2024
morrisonlevi added a commit that referenced this pull request Jun 10, 2024
This shrinks our memory footprint and reduces our CPU (but just a
smidge, not a big change).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:performance profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants