Ensure DDTRACE_G(active_stack) is always NULL when the root span is being pushed #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing pushed I have zero idea _how_ this happened, given that I'm unable to reproduce it, but a core dump indicated that the memory it pointed to was from the previous request. While this is not a very proper fix (as this should not be possible in the first place), it mitigates the effects. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
realFlowControl
approved these changes
Jun 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2701 +/- ##
=========================================
Coverage 77.96% 77.96%
Complexity 2212 2212
=========================================
Files 227 227
Lines 26551 26552 +1
Branches 988 988
=========================================
+ Hits 20701 20702 +1
Misses 5324 5324
Partials 526 526
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
BenchmarksBenchmark execution time: 2024-06-10 11:28:42 Comparing candidate commit 4157bd2 in PR branch Found 3 performance improvements and 1 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics. scenario:LaravelBench/benchLaravelOverhead
scenario:PDOBench/benchPDOBaseline
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverheadWithDBM
|
morrisonlevi
pushed a commit
that referenced
this pull request
Jun 10, 2024
…eing pushed (#2701) I have zero idea _how_ this happened, given that I'm unable to reproduce it, but a core dump indicated that the memory it pointed to was from the previous request. While this is not a very proper fix (as this should not be possible in the first place), it mitigates the effects. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have zero idea how this happened, given that I'm unable to reproduce it, but a core dump indicated that the memory it pointed to was from the previous request. While this is not a very proper fix (as this should not be possible in the first place), it mitigates the effects.
So, better a mitigation than a crash... :-)