-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix global priority sampling #2728
Conversation
646eeec
to
2ec3e4f
Compare
BenchmarksBenchmark execution time: 2024-07-15 18:13:41 Comparing candidate commit 2999e5c in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics. scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverheadWithDBM
scenario:TraceSerializationBench/benchSerializeTrace
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure you have already seen it, but some snapshots need updating it seems
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2728 +/- ##
=========================================
Coverage 77.96% 77.96%
Complexity 2216 2216
=========================================
Files 227 227
Lines 26643 26644 +1
Branches 989 989
=========================================
+ Hits 20771 20772 +1
Misses 5346 5346
Partials 526 526
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
The global priority sampling was not recognized as explicit sampling and thus ignored. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bc9a75a
to
ec99b2e
Compare
ec99b2e
to
2999e5c
Compare
The global priority sampling was not recognized as explicit sampling and thus ignored.