Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global priority sampling #2728

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Jun 21, 2024

The global priority sampling was not recognized as explicit sampling and thus ignored.

@bwoebi bwoebi requested a review from a team as a code owner June 21, 2024 10:28
@bwoebi bwoebi force-pushed the bob/fix-global-priority-sampling branch 2 times, most recently from 646eeec to 2ec3e4f Compare June 21, 2024 10:47
@bwoebi bwoebi requested a review from a team as a code owner June 21, 2024 10:47
@pr-commenter
Copy link

pr-commenter bot commented Jun 21, 2024

Benchmarks

Benchmark execution time: 2024-07-15 18:13:41

Comparing candidate commit 2999e5c in PR branch bob/fix-global-priority-sampling with baseline commit 4c3832d in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+9.861µs; +16.238µs] or [+3.615%; +5.953%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+10.665µs; +16.878µs] or [+3.586%; +5.675%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-9.918µs; -6.582µs] or [-4.995%; -3.315%]

Copy link
Contributor

@pablomartinezbernardo pablomartinezbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure you have already seen it, but some snapshots need updating it seems

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.96%. Comparing base (4c3832d) to head (2999e5c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2728   +/-   ##
=========================================
  Coverage     77.96%   77.96%           
  Complexity     2216     2216           
=========================================
  Files           227      227           
  Lines         26643    26644    +1     
  Branches        989      989           
=========================================
+ Hits          20771    20772    +1     
  Misses         5346     5346           
  Partials        526      526           
Flag Coverage Δ
appsec-extension 69.19% <ø> (ø)
tracer-extension 78.81% <100.00%> (+<0.01%) ⬆️
tracer-php 80.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/serializer.c 81.27% <100.00%> (+0.01%) ⬆️
src/DDTrace/Span.php 79.45% <100.00%> (ø)
src/DDTrace/Tracer.php 82.43% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3832d...2999e5c. Read the comment docs.

The global priority sampling was not recognized as explicit sampling and thus ignored.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/fix-global-priority-sampling branch from bc9a75a to ec99b2e Compare July 15, 2024 16:22
@bwoebi bwoebi force-pushed the bob/fix-global-priority-sampling branch from ec99b2e to 2999e5c Compare July 15, 2024 17:46
@bwoebi bwoebi merged commit e6d3dac into master Jul 15, 2024
662 of 668 checks passed
@bwoebi bwoebi deleted the bob/fix-global-priority-sampling branch July 15, 2024 19:34
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants