Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(profiling): fork handling #2747

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

morrisonlevi
Copy link
Collaborator

Description

This refactors the fork handling of profiler. This is roughly an extraction of work that was done in #2714 but not yet merged. That PR has conflicts to fix anyway, so may as well pull out the unrelated refactoring.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Jul 5, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 5, 2024

Benchmarks

Benchmark execution time: 2024-07-05 17:57:08

Comparing candidate commit be85648 in PR branch levi/fork-refactor with baseline commit ec095eb in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.51%. Comparing base (ec095eb) to head (be85648).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2747      +/-   ##
============================================
+ Coverage     77.95%   79.51%   +1.55%     
  Complexity     2216     2216              
============================================
  Files           227      201      -26     
  Lines         26637    22612    -4025     
  Branches        989        0     -989     
============================================
- Hits          20765    17980    -2785     
+ Misses         5346     4632     -714     
+ Partials        526        0     -526     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.80% <ø> (ø)
tracer-php 80.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec095eb...be85648. Read the comment docs.

@morrisonlevi morrisonlevi marked this pull request as ready for review July 5, 2024 21:13
@morrisonlevi morrisonlevi requested a review from a team as a code owner July 5, 2024 21:13
@morrisonlevi morrisonlevi merged commit 2dc6bac into master Jul 8, 2024
648 of 650 checks passed
@morrisonlevi morrisonlevi deleted the levi/fork-refactor branch July 8, 2024 15:21
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 8, 2024
estringana pushed a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants