Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sampler #2761

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Improve sampler #2761

merged 3 commits into from
Jul 17, 2024

Conversation

estringana
Copy link
Contributor

@estringana estringana commented Jul 16, 2024

Description

There have been error when more than one request was running on parallel due to the sampler not managing it properly. This PR refactor the sampler to stop these errors.

APPSEC-53993

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.96%. Comparing base (3053d70) to head (3a9942b).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2761      +/-   ##
============================================
- Coverage     79.52%   77.96%   -1.57%     
  Complexity     2216     2216              
============================================
  Files           201      227      +26     
  Lines         22619    26644    +4025     
  Branches          0      989     +989     
============================================
+ Hits          17987    20772    +2785     
- Misses         4632     5346     +714     
- Partials          0      526     +526     
Flag Coverage Δ
appsec-extension 69.19% <ø> (?)
tracer-extension 78.81% <ø> (ø)
tracer-php 80.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3053d70...3a9942b. Read the comment docs.

@estringana estringana marked this pull request as ready for review July 17, 2024 08:21
@estringana estringana requested a review from a team as a code owner July 17, 2024 08:21
appsec/src/helper/sampler.hpp Outdated Show resolved Hide resolved
@estringana estringana merged commit 7491b28 into master Jul 17, 2024
668 of 673 checks passed
@estringana estringana deleted the estringana/improve-sampler branch July 17, 2024 12:58
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants