Update the expected telemetry tags for OTel env-var mapping

[mcculls]

Description

The RFC has been revised since #2691

The expected telemetry tags when reporting OTel env-var mapping issues now use snake-case:

 config.datadog       -> config_datadog
 config.opentelemetry -> config_opentelemetry

The expected tag values should also be lower-case.

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-07-25 11:24:47

Comparing candidate commit fbc56c4 in PR branch mcculls/otel-env-var-metric-tag-update with baseline commit d8d904a in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

• 🟩 execution_time [-18.360µs; -14.809µs] or [-9.956%; -8.030%]

scenario:PDOBench/benchPDOOverhead

• 🟩 execution_time [-18.132µs; -16.355µs] or [-6.319%; -5.700%]

scenario:PDOBench/benchPDOOverheadWithDBM

• 🟩 execution_time [-18.263µs; -16.221µs] or [-5.877%; -5.220%]

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.51%. Comparing base (d8d904a) to head (fbc56c4).

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2775      +/-   ##
============================================
- Coverage     80.09%   78.51%   -1.58%     
  Complexity     2459     2459              
============================================
  Files           204      230      +26     
  Lines         23769    27794    +4025     
  Branches          0      989     +989     
============================================
+ Hits          19038    21823    +2785     
- Misses         4731     5445     +714     
- Partials          0      526     +526     

Flag	Coverage Δ
appsec-extension	69.19% <ø> (?)
tracer-extension	78.60% <0.00%> (ø)
tracer-php	82.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
ext/otel_config.c	79.50% <0.00%> (ø)

... and 26 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d904a...fbc56c4. Read the comment docs.

[bwoebi]

Looks simple enough to me, thanks :-)