Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2774: shared hooks removal caused xdebug end handler to be skipped #2780

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Jul 29, 2024

Fixing #2774, just copy pasting the necessary logic from normal entry removal.

@bwoebi bwoebi requested a review from a team as a code owner July 29, 2024 22:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (14de5d5) to head (e928685).

Files Patch % Lines
zend_abstract_interface/hook/hook.c 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2780      +/-   ##
============================================
- Coverage     80.81%   78.33%   -2.48%     
  Complexity     2452     2452              
============================================
  Files           144      170      +26     
  Lines         14329    18124    +3795     
  Branches          0      913     +913     
============================================
+ Hits          11580    14198    +2618     
- Misses         2749     3431     +682     
- Partials          0      495     +495     
Flag Coverage Δ
appsec-extension 69.27% <ø> (?)
tracer-extension 78.19% <0.00%> (-0.30%) ⬇️
tracer-php 81.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
zend_abstract_interface/hook/hook.c 54.49% <0.00%> (-0.29%) ⬇️

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14de5d5...e928685. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Jul 29, 2024

Benchmarks

Benchmark execution time: 2024-08-20 13:01:37

Comparing candidate commit fe27b08 in PR branch bob/fix-2774 with baseline commit d75a84d in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+3.840µs; +5.540µs] or [+2.676%; +3.860%]

Copy link
Contributor

@iamluc iamluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

But some paths in the xdebug tests must be fixed

@bwoebi bwoebi force-pushed the bob/fix-2774 branch 3 times, most recently from 6220cf9 to fe27b08 Compare August 20, 2024 12:35
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi merged commit b21e6a0 into master Aug 21, 2024
517 of 535 checks passed
@bwoebi bwoebi deleted the bob/fix-2774 branch August 21, 2024 11:34
@github-actions github-actions bot added this to the 1.3.0 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants