Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup with spaces in path to php binary #2803

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Aug 20, 2024

e.g. C:\Program Files\php\php.exe

e.g. C:\Program Files\php\php.exe
@bwoebi bwoebi requested a review from a team as a code owner August 20, 2024 19:18
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (14de5d5) to head (f9ffd42).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2803   +/-   ##
=========================================
  Coverage     80.74%   80.74%           
  Complexity     2452     2452           
=========================================
  Files           144      144           
  Lines         14344    14344           
=========================================
  Hits          11582    11582           
  Misses         2762     2762           
Flag Coverage Δ
tracer-extension 78.27% <ø> (ø)
tracer-php 81.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14de5d5...f9ffd42. Read the comment docs.

@bwoebi bwoebi merged commit 5f56332 into master Aug 21, 2024
606 of 641 checks passed
@bwoebi bwoebi deleted the bob/fix-whitespace-in-php-binary branch August 21, 2024 11:31
@github-actions github-actions bot added this to the 1.3.0 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants