Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only warn on missing json extension #2805

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

realFlowControl
Copy link
Member

Description

Fixes #2787

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl requested a review from a team as a code owner August 22, 2024 12:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (65395da) to head (9747b38).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2805      +/-   ##
============================================
+ Coverage     78.49%   81.07%   +2.57%     
  Complexity     2516     2516              
============================================
  Files           173      146      -27     
  Lines         18676    14647    -4029     
  Branches        975        0     -975     
============================================
- Hits          14660    11875    -2785     
+ Misses         3479     2772     -707     
+ Partials        537        0     -537     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.19% <ø> (ø)
tracer-php 82.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65395da...9747b38. Read the comment docs.

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@realFlowControl realFlowControl merged commit 4b2f6db into master Aug 22, 2024
606 of 641 checks passed
@realFlowControl realFlowControl deleted the florian/datadog-setup-softfail branch August 22, 2024 15:06
@realFlowControl realFlowControl self-assigned this Aug 22, 2024
@github-actions github-actions bot added this to the 1.3.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants