Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation after alpine container upgrade #2811

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Aug 24, 2024

Fixing a few -Werror false positives.

@bwoebi bwoebi requested a review from a team as a code owner August 24, 2024 02:51
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.49%. Comparing base (4b2f6db) to head (727100b).

Files Patch % Lines
zend_abstract_interface/symbols/lookup.c 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2811      +/-   ##
============================================
- Coverage     81.11%   78.49%   -2.63%     
  Complexity     2516     2516              
============================================
  Files           146      173      +27     
  Lines         14647    18679    +4032     
  Branches          0      975     +975     
============================================
+ Hits          11881    14662    +2781     
- Misses         2766     3480     +714     
- Partials          0      537     +537     
Flag Coverage Δ
appsec-extension 69.12% <ø> (?)
tracer-extension 78.19% <66.66%> (-0.01%) ⬇️
tracer-php 82.27% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
zend_abstract_interface/symbols/call.c 92.63% <100.00%> (+0.04%) ⬆️
zend_abstract_interface/symbols/lookup.c 82.43% <50.00%> (-0.32%) ⬇️

... and 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2f6db...727100b. Read the comment docs.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi merged commit 8b54f42 into master Aug 26, 2024
11 of 93 checks passed
@bwoebi bwoebi deleted the bob/fix-alpine-compile branch August 26, 2024 10:41
@github-actions github-actions bot added this to the 1.3.0 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants