Do not implicitly fall back to spl_autoload() if no autoloader is registered on PHP 7 #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/fix-autoload
branch
from
ea77ced
to
85e138a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2822 +/- ##
============================================
- Coverage 75.31% 73.97% -1.34%
Complexity 2516 2516
============================================
Files 146 173 +27
Lines 14650 18679 +4029
Branches 0 975 +975
============================================
+ Hits 11033 13818 +2785
- Misses 3617 4324 +707
- Partials 0 537 +537
Flags with carried forward coverage won't be shown. Click here to find out more. see 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bwoebi
force-pushed
the
bob/fix-autoload
branch
from
85e138a
to
c21306a
Compare
…istered on PHP 7 This could lead to accidental inclusion of files, breaking __autoload() and possibly including the wrong file. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/fix-autoload
branch
from
c21306a
to
0b1f9b0
Compare
BenchmarksBenchmark execution time: 2024-08-29 20:46:23 Comparing candidate commit 0b1f9b0 in PR branch Found 5 performance improvements and 1 performance regressions! Performance is the same for 172 metrics, 0 unstable metrics. scenario:ContextPropagationBench/benchExtractHeaders128Bit-opcache
scenario:EmptyFileBench/benchEmptyFileBaseline-opcache
scenario:EmptyFileBench/benchEmptyFileOverhead
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverheadWithDBM
scenario:WordPressBench/benchWordPressOverhead
|
iamluc
approved these changes
Aug 30, 2024
| @@ -0,0 +1,23 @@ | |||
| --TEST-- | |||
| Execute the default spl_autoload implementation if spl_autoload_register() is called without args | |||
estringana
pushed a commit
that referenced
this pull request
Sep 12, 2024
…istered on PHP 7 (#2822) * Do not implicitly fall back to spl_autoload() if no autoloader is registered on PHP 7 This could lead to accidental inclusion of files, breaking __autoload() and possibly including the wrong file. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could lead to accidental inclusion of files, breaking __autoload() and possibly including the wrong file.