Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with double parent key in tracestate #2837

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Sep 5, 2024

Access of span_parent_key would be NULL on second 'p'.

Access of span_parent_key would be NULL on second 'p'.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi requested a review from a team as a code owner September 5, 2024 20:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.49%. Comparing base (735db41) to head (a688a78).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2837      +/-   ##
============================================
- Coverage     81.10%   78.49%   -2.62%     
  Complexity     2516     2516              
============================================
  Files           146      173      +27     
  Lines         14651    18680    +4029     
  Branches          0      975     +975     
============================================
+ Hits          11883    14662    +2779     
- Misses         2768     3481     +713     
- Partials          0      537     +537     
Flag Coverage Δ
appsec-extension 69.12% <ø> (?)
tracer-extension 78.17% <ø> (ø)
tracer-php 82.27% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735db41...a688a78. Read the comment docs.

@bwoebi bwoebi merged commit 37418fd into master Sep 5, 2024
488 of 491 checks passed
@bwoebi bwoebi deleted the bob/fix-double-parentkey branch September 5, 2024 21:40
@bwoebi bwoebi added this to the 1.3.1 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants