Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROF-8667] Split profiling tests into ractor and non-ractor suites. #3320

Merged
merged 6 commits into from
Dec 13, 2023
Merged

[PROF-8667] Split profiling tests into ractor and non-ractor suites. #3320

merged 6 commits into from
Dec 13, 2023

Commits on Dec 12, 2023

  1. [PROF-8667] Split profiling tests into ractor and non-ractor suites.

    @AlexJF
    AlexJF committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    48c37cf View commit details
    Browse the repository at this point in the history

  2. [PROF-8667] Keep native ext compilation in main due to profiling conf… 

    …ig tests
    @AlexJF
    AlexJF committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    2f69cbd View commit details
    Browse the repository at this point in the history

  3. [PROF-8667] Remove redundant profiling core spec and simplify deps

    @AlexJF
    AlexJF committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    0143cd4 View commit details
    Browse the repository at this point in the history

  4. [PROF-8667] Fix issues with 2 tests that would otherwise always be sk… 

    …ipped in CI.
    @AlexJF
    AlexJF committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a44329a View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Minor: Fix rspec warning 

    RSpec was warning

> WARNING: An expectation of `:run` was set on `nil`.

because the setup task may not be loaded.

We can remove this `allow` because the whole component is being mocked,
so the setup task will never get run in this case.
    @ivoanjo
    ivoanjo committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    4ab10c2 View commit details
    Browse the repository at this point in the history

  2. [PROF-8667] Go back to using an instance_double but with string.

    @AlexJF
    AlexJF committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    b02a143 View commit details
    Browse the repository at this point in the history