Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minitest detection spec #3445

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Feb 7, 2024

What does this PR do?

Fix failing spec on MacOS and CircleCI, where steep is bundled.

steep depends on activesupport, which depends on minitest. So the test is activated on CI.

With no version constraint on the version, Minitest release 5.22.1 on Feb 6
https://github.com/minitest/minitest/blob/master/History.rdoc#label-5.22.1+-2F+2024-02-06

Our test suite failed with such change.

To fix it, add a dummy test case so the process status would be successful.

Note: This is something we should be working on continuing improving our environment.

@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Feb 7, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 7, 2024 12:37
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner February 7, 2024 12:37
@TonyCTHsu TonyCTHsu self-assigned this Feb 7, 2024
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for debugging this!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e449874) 98.26% compared to head (8fa1830) 98.26%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3445      +/-   ##
==========================================
- Coverage   98.26%   98.26%   -0.01%     
==========================================
  Files        1268     1268              
  Lines       74394    74397       +3     
  Branches     3481     3481              
==========================================
  Hits        73106    73106              
- Misses       1288     1291       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc merged commit 1511556 into master Feb 7, 2024
219 checks passed
@marcotc marcotc deleted the tonycthsu/fix-minitest-detection-test branch February 7, 2024 19:35
@github-actions github-actions bot added this to the 1.21.0 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants