Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service used by dbm between span.service and peer.service #3459

Closed
wants to merge 1 commit into from

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Feb 15, 2024

2.0 Upgrade Guide notes

What does this PR do?
Changes configuration to only use peer.service as the propagated dbm service if the service name for the span is nil or the global default value.

This will only trigger when the user enables DD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLED and intends to use peer.service as the distinguishing factor between spans instead of span.service.

Motivation:

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Feb 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65f12dd) 98.23% compared to head (3c7169f) 98.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3459   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files        1270     1270           
  Lines       74802    74825   +23     
  Branches     3510     3512    +2     
=======================================
+ Hits        73479    73504   +25     
+ Misses       1323     1321    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zarirhamza zarirhamza marked this pull request as ready for review February 15, 2024 21:31
@zarirhamza zarirhamza requested a review from a team as a code owner February 15, 2024 21:31
@zarirhamza zarirhamza closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants