Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for TraceDigest generation #3475

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Add benchmark for TraceDigest generation #3475

merged 3 commits into from
Feb 23, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Feb 22, 2024

Follow up to #3474

What does this PR do?

Adds a benchmark that measures the process of generating a TraceDigest from an active trace.
This happens whenever distributed tracing propagation happens.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested a review from a team as a code owner February 22, 2024 22:51
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Feb 22, 2024
Base automatically changed from bm-writer to 2.0 February 23, 2024 20:50
@pr-commenter
Copy link

pr-commenter bot commented Feb 23, 2024

Benchmarks

Benchmark execution time: 2024-02-23 21:40:29

Comparing candidate commit a72e37b in PR branch bm-digest with baseline commit 110997c in branch 2.0.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 1 unstable metrics.

@marcotc marcotc merged commit d25ae75 into 2.0 Feb 23, 2024
123 of 132 checks passed
@marcotc marcotc deleted the bm-digest branch February 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants