[NO-TICKET] Upgrade to libdatadog 8 #3579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR upgrades dd-trace-rb to use libdatadog 8. Even though there were a few breaking API changes, none of those APIs were being used in the Ruby profiler, so it's a very minor bump for us. **Motivation:** This version includes a number of fixes and tweaks that will finally enable us to land the crash tracker feature (#3384). **Additional Notes:** I'm opening this PR as a draft as libdatadog 8 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is. **How to test the change?** Our existing test coverage includes libdatadog testing, so a green CI is good here :)
|
Update: I've spotted an issue in the upstream libdatadog 8.0.0 distribution package that makes the crashtracker feature not work. I'll pause this until that gets fixed, as I suspect we'll need an 8.0.1. |
|
Superseded by libdatadog9: #3627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades dd-trace-rb to use libdatadog 8.
Even though there were a few breaking API changes, none of those APIs were being used in the Ruby profiler, so it's a very minor bump for us.
Motivation:
This version includes a number of fixes and tweaks that will finally enable us to land the crash tracker feature (#3384).
Additional Notes:
I'm opening this PR as a draft as libdatadog 8 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is.
How to test the change?
Our existing test coverage includes libdatadog testing, so a green CI is good here :)