Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade net-http-persistent library to new version #54

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

javiercri
Copy link
Contributor

@javiercri javiercri commented May 11, 2022

Signed-off-by: Javier Criado Marcos jcriadomarco@vmware.com

What does this PR do?

Update net-http-persistent to last version

Motivation

We are struggling a lot while using these plugin along with splunk or elastic, because this plugin are using version 4.0.1 of net-http-persistent library. There is no breaking changes between the 2 version of net-http-persistent library

Additional Notes

Here i will send you some examples of these problems in other repos:

Signed-off-by: Javier Criado Marcos <jcriadomarco@vmware.com>
@javiercri javiercri changed the title chore: upgrade net-http-persistent library to now version chore: upgrade net-http-persistent library to new version May 11, 2022
@javiercri
Copy link
Contributor Author

Hello!
Let me know if you need something else @remeh

@remeh
Copy link
Contributor

remeh commented May 31, 2022

Hey @javiercri, sorry for the late reply. I'll look into this.

@remeh
Copy link
Contributor

remeh commented Jun 1, 2022

Thanks for your contribution @javiercri 👍 I'll release a new gem in a few minutes to ship your change.

@remeh remeh merged commit 88e2ac6 into DataDog:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants