[SIEMINT-69] DDS: Cisco Secure Endpoint: Crawler Integration Without Assets #17865
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # CHANGELOG - cisco_secure_endpoint | ||
|
|
||
| <!-- towncrier release notes start --> | ||
|
|
||
| ## 1.0.0 / 2024-06-17 | ||
|
|
||
| ***Added***: | ||
|
|
||
| * Initial Release | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # Agent Check: cisco_secure_endpoint | ||
|
|
||
| ## Overview | ||
|
|
||
| This check monitors [Cisco Secure Endpoint][1]. | ||
|
|
||
| ## Setup | ||
|
|
||
| ### Installation | ||
|
|
||
| The Cisco Secure Endpoint check is included in the [Datadog Agent][2] package. | ||
| No additional installation is needed on your server. | ||
|
|
||
| ### Configuration | ||
|
|
||
| 1. <List of steps to configure this integration> | ||
|
|
||
| ### Validation | ||
|
|
||
| <Steps to validate integration is functioning as expected> | ||
|
|
||
| ## Data Collected | ||
|
|
||
| ### Metrics | ||
|
|
||
| The Cisco Secure Endpoint integration does not include any metrics. | ||
|
|
||
| ### Service Checks | ||
|
|
||
| The Cisco Secure Endpoint integration does not include any service checks. | ||
|
|
||
| ### Events | ||
|
|
||
| The Cisco Secure Endpoint integration does not include any events. | ||
|
|
||
| ## Troubleshooting | ||
|
|
||
| Need help? Contact [Datadog support][3]. | ||
|
|
||
| [1]: **LINK_TO_INTEGRATION_SITE** | ||
| [2]: https://app.datadoghq.com/account/settings#agent | ||
| [3]: https://docs.datadoghq.com/help/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { | ||
| "manifest_version": "2.0.0", | ||
| "app_uuid": "9636c2eb-34f6-4aa4-a236-c39e47b21c79", | ||
| "app_id": "cisco-secure-endpoint", | ||
| "display_on_public_website": false, | ||
| "tile": { | ||
| "overview": "README.md#Overview", | ||
| "configuration": "README.md#Setup", | ||
| "support": "README.md#Support", | ||
| "changelog": "CHANGELOG.md", | ||
| "description": "Gain insights into Cisco Secure Endpoint logs", | ||
| "title": "cisco_secure_endpoint", | ||
|
There was a problem hiding this comment. Have made the change. |
||
| "media": [], | ||
| "classifier_tags": [ | ||
| "Category::Log Collection", | ||
| "Category::Security", | ||
| "Submitted Data Type::Logs" | ||
| ] | ||
| }, | ||
| "assets": { | ||
| "integration": { | ||
| "auto_install": false, | ||
| "source_type_id": 18601889, | ||
| "source_type_name": "Cisco Secure Endpoint", | ||
| "events": { | ||
| "creates_events": false | ||
| }, | ||
| "service_checks": { | ||
| "metadata_path": "assets/service_checks.json" | ||
| } | ||
| } | ||
| }, | ||
| "author": { | ||
| "support_email": "help@datadoghq.com", | ||
| "name": "Datadog", | ||
| "homepage": "https://www.datadoghq.com", | ||
| "sales_email": "info@datadoghq.com" | ||
| }, | ||
| "oauth": {} | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by this changelog entry.
Is this a logs integration or does it only have assets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iliakur these "without assets" PRs are meant to establish the integration / integration id / source type id so that the crawler can be developed for it. so we don't typically review the asset content in these PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, so if there's a crawler that needs to be written, could you use some template that adds python package scaffolding as well please?
Our changelogs are of 2 kinds:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe, the
validate-repositoryworkflow is complaining about this exact thing in fact ;)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see... @ankitarajput-crest I think you need to remove this line (and just a heads-up that if you use the
metrics_crawlertype when runningddev createit'll generate this file correctly for you)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nathanmadams will this end up having python code though? If yes, we need to keep the towncrier line and get rid of the 1.0.0 release entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python code won't be a part of this repo but crawler repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhargavnariyanicrest sounds good! in that case let's do as Nathan says: we get rid of the towncrier header and keep the v1.0.0 release section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iliakur @nathanmadams
Thanks for the comment. Have made the changes.