[Backport 7.56.x] [mysql] revert default read_timeout #18098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-agent-integrations-bot[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
* revert default read_timeout * add changelog (cherry picked from commit 4d47709)
nenadnoveljic
approved these changes
Jul 22, 2024
Kyle-Neale
approved these changes
Jul 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4d47709 from #18097.
What does this PR do?
This PR reverts the default 10s read_timeout for MySQL integration as we see connection leaks in rare cases.
Motivation
Due to the default 10s read_timeout, mysql queries can sometimes timeout and result in uncaught exception. The uncaught exceptions that happen in DBM async threads will cause those threads to shutdown. A new thread will be started with a new database connection. In rare cases, the database connection from prior thread is closed on the client side but remains open on the database server side. This has resulted in more new connections being opened with datadog user and caused connection surge on the database.
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged