Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for license validation #18591

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix test for license validation #18591

merged 1 commit into from
Sep 16, 2024

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Sep 16, 2024

What does this PR do?

Fixes the mock fixture data for a ddev test.

Motivation

The test is relying on real data in the master branch. So it passed when for the PR that changed this data but as soon as we merged to master it started failing.

I have it on my radar to fix this testing setup, it's a drag.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (35be561) to head (cfe40d3).
Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
ddev 88.02% <100.00%> (+0.67%) ⬆️
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@iliakur iliakur merged commit ec07846 into master Sep 16, 2024
62 of 64 checks passed
@iliakur iliakur deleted the ik/AI-3958/fix-ddev-test branch September 16, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants