update kafka readme #18607
Merged
update kafka readme #18607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the note about DSM now that we display the product connection as a UI component in app
Remove the note about DSM now that we display the product connection as a UI component in app
moreauowen
previously approved these changes
Sep 17, 2024
steveny91
previously approved these changes
Sep 17, 2024
estherk15
previously approved these changes
Sep 17, 2024
eho1307
dismissed stale reviews from estherk15, steveny91, and moreauowen
via
6478b78
moreauowen
reviewed
Sep 17, 2024
| @@ -143,7 +141,6 @@ sudo service datadog-agent restart | |||
| [13]: https://www.datadoghq.com/blog/monitoring-kafka-performance-metrics | |||
| [14]: https://www.datadoghq.com/blog/collecting-kafka-performance-metrics | |||
| [15]: https://www.datadoghq.com/blog/monitor-kafka-with-datadog | |||
| [16]: https://www.datadoghq.com/product/data-streams-monitoring/ | |||
There was a problem hiding this comment.
since this is being removed I wonder if the other numbers should be shifted down
estherk15
approved these changes
Sep 17, 2024
Kyle-Neale
approved these changes
Sep 17, 2024
moreauowen
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the note about DSM now that we display the product connection as a UI component in app so there isn't redundant info. See the example: https://app.datadoghq.com/marketplace/integration/kafka
See https://datadoghq.atlassian.net/browse/ECOS-1687
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged