[PROF-9742] Package libdatadog v9.0.0 for Ruby #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg (It's also very similar to the v7.0.0 release PR). It also includes a tiny paper cut fix: it disables the Rake `build` task which is the default way to package a Ruby gem, since we have our own custom packaging steps in the `Rakefile`. **Motivation:** Enable Ruby to use libdatadog v9.0.0. **Additional Notes:** We ended up not packaging the previous release (v8) for Ruby, so we're directly jumping from v7 to v9. **How to test the change?** I've tested this release locally using the changes in DataDog/dd-trace-rb#3627 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
=======================================
Coverage 64.83% 64.83%
=======================================
Files 183 183
Lines 22359 22359
=======================================
Hits 14496 14496
Misses 7863 7863
|
danielsn
approved these changes
May 9, 2024
Yes, but I haven't had the chance to do it so far :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg
(It's also very similar to the v7.0.0 release PR).
It also includes a tiny paper cut fix: it disables the Rake
buildtask which is the default way to package a Ruby gem, since we have our own custom packaging steps in theRakefile.Motivation
Enable Ruby to use libdatadog v9.0.0.
Additional Notes
We ended up not packaging the previous release (v8) for Ruby, so we're directly jumping from v7 to v9.
How to test the change?
I've tested this release locally using the changes in DataDog/dd-trace-rb#3627 .
As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.