Live debugger parsing, expression evaluation, sender, redaction and FFI #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/remote-config
branch
3 times, most recently
from
b89fdee
to
95c7998
Compare
bwoebi
force-pushed
the
bob/live-debugger
branch
3 times, most recently
from
8ed0173
to
dd7c3c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
==========================================
- Coverage 73.06% 71.43% -1.63%
==========================================
Files 252 266 +14
Lines 35959 39099 +3140
==========================================
+ Hits 26274 27931 +1657
- Misses 9685 11168 +1483
|
bwoebi
force-pushed
the
bob/live-debugger
branch
from
9dbd596
to
bc824b8
Compare
bwoebi
changed the title
p-datadog
reviewed
Jul 1, 2024
live-debugger-ffi/src/data.rs
Outdated
| Probe { | ||
| id: from.id.as_str().into(), | ||
| version: from.version, | ||
| language: from.language.as_ref().map(|s| s.as_str().into()).into(), |
There was a problem hiding this comment.
Is there a note/explanation somewhere for what this is for? Are there multiple string types being used?
There was a problem hiding this comment.
Not sure what you are asking? Why I'm collecting the language? What this particular line of rust does? Or just asking what I'm doing to convert an Option<String> into an Option<CharSlice>?
There was a problem hiding this comment.
Apologies for being unclear. I was asking why language: from.language would be insufficient, for my general education on how rust works.
There was a problem hiding this comment.
Ah, yeah, just the conversion of the value within the Option to something FFI understands.
bwoebi
force-pushed
the
bob/live-debugger
branch
7 times, most recently
from
1af5976
to
2e750e5
Compare
bwoebi
force-pushed
the
bob/remote-config
branch
4 times, most recently
from
2ca32a8
to
9375778
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/live-debugger
branch
2 times, most recently
from
4de54ed
to
c55ff07
Compare
Otherwise concurrency in tests will lead to flakiness. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/live-debugger
branch
from
c55ff07
to
5c1a59f
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing goes through an intermediate step, which serde can simply deserialize to, handling which isn't possible by serde is then translated to working structures.
The Evaluator (feel free to clean up lifetime handling if possible. Spent far too much time fighting the borrow checker. Maybe my code is already perfect and I don't know it.) handles all evaluation of the expression language, iteration, error handling etc. and defers to some callbacks for actual evaluation of the values.