Use serde_bytes for meta_struct #540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/meta_struct-serde_bytes
branch
2 times, most recently
from
0a36ced
to
8fb9346
Compare
Otherwise meta_struct will be serialized as an array of integers instead of a byte string, breaking the expected representation. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/meta_struct-serde_bytes
branch
from
8fb9346
to
3ae1507
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
=======================================
Coverage 70.58% 70.58%
=======================================
Files 206 206
Lines 28129 28129
=======================================
Hits 19856 19856
Misses 8273 8273
|
BenchmarksThis comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output. |
bantonsson
reviewed
Aug 2, 2024
There was a problem hiding this comment.
Well, since we're not going to send v0.7 (or at least not optimize or test that) from the sidecar, I don't know how ASM will be able to use meta_struct.
I'm not saying that the fix is wrong, but I can only see meta_struct being used in an agentless setting, when sending directly to intake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise meta_struct will be serialized as an array of integers instead of a byte string, breaking the expected representation.
Appsec is trying to use it, but breaking when using the sidecar trace sender.