Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tel v2 schema for app-started payload requires 'configuration' #543

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

cataphract
Copy link
Contributor

What does this PR do?

Fixes app-started telemetry messages that don't include the "configuration" key. This key is required by the schema.

Motivation

Failing system tests: DataDog/system-tests#2785

Additional Notes

System tests started failing once DataDog/dd-trace-php#2757 was merged and telemetry messages were actually sent.

@cataphract cataphract requested a review from a team as a code owner July 22, 2024 09:23
@cataphract cataphract requested a review from omerli July 22, 2024 09:23
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.45%. Comparing base (94bee0c) to head (d7779ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   70.45%   70.45%           
=======================================
  Files         208      208           
  Lines       28414    28414           
=======================================
  Hits        20020    20020           
  Misses       8394     8394           
Components Coverage Δ
crashtracker 25.53% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 50.00% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.43% <ø> (ø)
ddcommon-ffi 75.29% <ø> (ø)
ddtelemetry 58.95% <ø> (ø)
ipc 84.13% <ø> (ø)
profiling 78.09% <ø> (ø)
profiling-ffi 56.76% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 35.42% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 71.14% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 91.03% <ø> (ø)

@pr-commenter
Copy link

pr-commenter bot commented Jul 22, 2024

Benchmarks

This comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output.

@bwoebi bwoebi merged commit 89d4831 into main Jul 22, 2024
42 checks passed
@bwoebi bwoebi deleted the glopes/fix-bad-app-started branch July 22, 2024 16:01
ekump pushed a commit that referenced this pull request Jul 22, 2024
Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants